Skip to content

CLDSRV-893, CLDSRV-894, CLDSRV-896: Backport bucket logging fixes to hotfix/9.2.24#6158

Merged
bert-e merged 4 commits intohotfix/9.2.24from
bugfix/CLDSRV-893-CLDSRV-894-CLDSRV-896-hf-9.2.24
Apr 20, 2026
Merged

CLDSRV-893, CLDSRV-894, CLDSRV-896: Backport bucket logging fixes to hotfix/9.2.24#6158
bert-e merged 4 commits intohotfix/9.2.24from
bugfix/CLDSRV-893-CLDSRV-894-CLDSRV-896-hf-9.2.24

Conversation

@dvasilas
Copy link
Copy Markdown
Contributor

@dvasilas dvasilas commented Apr 20, 2026 •
edited by atlassian bot
Loading

Backports CLDSRV-893, CLDSRV-894, and CLDSRV-896 to hotfix/9.2.24.

dvasilas added 3 commits April 20, 2026 14:34
@dvasilas
CLDSRV-893: Return ARN for assumed-role requesters in access logs
6ac8392 
The getRequester() function fell through to the canonical ID for
assumed-role sessions, producing a space-containing string that
broke space-delimited log parsers.

(cherry picked from commit 46a99ae)
@dvasilas
CLDSRV-894: Report turn-around time for PutObject and UploadPart
e30397b 
Server access logs did not report turn-around time for PutObject and
UploadPart while all other operations reported it correctly.
AWS reports turn-around time for these operations.

(cherry picked from commit 314ba8c)
@dvasilas
CLDSRV-896: Emit IAM ARN in access log Requester field for IAM users
eb9c1c0 
When an IAM user makes a request, the Requester field in the bucket
server access log was emitted as userName:accountName. AWS emits an
ARN of the form arn:aws:iam::<accountId>:user/<userName>. Use the
IAM ARN that Vault already provides via authInfo to match the AWS S3
server access log format.

(cherry picked from commit fc18430)
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 20, 2026

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 20, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-893 contains:

  • 9.2.36

  • 9.3.7

  • 9.4.0

Considering where you are trying to merge, I expected to find at least:

  • 9.2.24.1

Please check the Fix Version/s of CLDSRV-893, or the target
branch of this pull request.

@dvasilas dvasilas changed the title CLDSRV-893, CLDSRV-894, CLDSRV-896: Backport bucket access log fixes to hotfix/9.2.24 CLDSRV-893, CLDSRV-894, CLDSRV-896: Backport bucket logging fixes to hotfix/9.2.24 Apr 20, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.49%. Comparing base (9c0b28e) to head (15698bf).
⚠️ Report is 4 commits behind head on hotfix/9.2.24.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/api.js 90.16% <100.00%> (+0.24%) ⬆️
lib/utilities/serverAccessLogger.js 82.01% <100.00%> (+0.15%) ⬆️ 
@@              Coverage Diff               @@
##           hotfix/9.2.24    #6158   +/-   ##
==============================================
  Coverage          84.48%   84.49%           
==============================================
  Files                206      206           
  Lines              13173    13181    +8     
==============================================
+ Hits               11129    11137    +8     
  Misses              2044     2044
Flag Coverage Δ
file-ft-tests 67.70% <81.81%> (+0.08%) ⬆️
kmip-ft-tests 28.25% <72.72%> (+0.06%) ⬆️
mongo-v0-ft-tests 68.89% <81.81%> (+0.02%) ⬆️
mongo-v1-ft-tests 68.93% <81.81%> (+0.07%) ⬆️
multiple-backend 35.28% <72.72%> (+0.03%) ⬆️
sur-tests 35.79% <72.72%> (+<0.01%) ⬆️
sur-tests-inflights 37.64% <72.72%> (+<0.01%) ⬆️
unit 69.77% <100.00%> (+0.06%) ⬆️
utapi-v2-tests 34.53% <72.72%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 20, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@dvasilas
Copy link
Copy Markdown
Contributor Author

dvasilas commented Apr 20, 2026

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 20, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/9.2.24

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2
  • development/9.3
  • development/9.4

Please check the status of the associated issue CLDSRV-893.

Goodbye dvasilas.

The following options are set: approve

@bert-e bert-e merged commit 15698bf into hotfix/9.2.24 Apr 20, 2026
31 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-893-CLDSRV-894-CLDSRV-896-hf-9.2.24 branch April 20, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-gramain jonathan-gramain jonathan-gramain approved these changes

@BourgoisMickael BourgoisMickael BourgoisMickael approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dvasilas @bert-e @jonathan-gramain @BourgoisMickael